-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete PDF output handler #367
base: dev
Are you sure you want to change the base?
Conversation
Everythnig was alredy prepairt and I just had to make some minor changes. I do not know why this was prepaired but not finished.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as you do not need drawing frames and BOM, this is fine. It does not solve your issue #354 then.
@martinrieder yes and no, Yes it does not add frames and so. And No since I originally just wanted a PDF output and was not interested in the frame, since PDF is just a robuster vector graphics format and is less dependent on the interpreter. |
Maybe we need to make some destinguishment through another CLI argument that would request BOM output, templates and metadata to be included, which is currently only supported for HTML. EDIT: Alternatively, the list of output formats for the |
@martinrieder wrote:
If you want to include a BOM in the diagram (as in #227) and optionally also a frame, then such extra elements will be added to all graphical output types, and controlling this by different output type specifiers makes no sense to me. A common specifyer for what to include in the diagram is then needed, and the HTML output should be adjusted accordingly to avoid doubled BOM and frame. |
Everything was already prepaired, and I just had to make some minor changes. I do not know why this was prepaired but not finished.